Skip to content

feat(metric): remove cookie column from request attributes in Metric … #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnabChatterjee20k merged 1 commit into from
Sep 3, 2026
Merged

feat(metric): remove cookie column from request attributes in Metric … #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Usage/Metric.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class Metric extends ArrayObject
'teamId', 'teamInternalId',
'country', 'region', 'hostname', 'ip',
// request attributes (firewall rule matching)
'protocol', 'accept', 'acceptLanguage', 'cookie', 'queryKeys',
'protocol', 'accept', 'acceptLanguage', 'queryKeys',
// premium geo
'city', 'continentCode', 'subdivisions',
'postalCode', 'latitude', 'longitude', 'timeZone', 'weatherCode',
Expand Down Expand Up @@ -91,7 +91,7 @@ class Metric extends ArrayObject
* - resourceType / resourceId / resourceInternalId: resource identity
* - teamId / teamInternalId: owning team identity
* - country / region / hostname / ip: geographic + caller origin
* - protocol / accept / acceptLanguage / cookie / queryKeys: request attributes (firewall rule matching)
* - protocol / accept / acceptLanguage / queryKeys: request attributes (firewall rule matching)
* - city / continentCode / subdivisions: premium geo location fields
* - postalCode / latitude / longitude / timeZone / weatherCode: premium geo location fields
* - isp / autonomousSystemNumber / autonomousSystemOrganization: premium network origin
Expand Down Expand Up @@ -657,10 +657,6 @@ public static function getEventSchema(): array
$stringColumn('protocol', 16),
$stringColumn('accept', 1024),
$stringColumn('acceptLanguage', 256),
// Cookie headers are large; size > maxVarchar (16381) makes this a
// TEXT column, stored off-page so it costs ~20 bytes toward the
// MariaDB 65535 row-size limit instead of size*4.
$stringColumn('cookie', 65535),
$stringColumn('queryKeys', 1024),
// premium geo
$stringColumn('city', 256),
Expand Down
2 changes: 1 addition & 1 deletion tests/Usage/MetricTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ public function testEventColumnsConstant(): void
'service', 'resourceType', 'resourceId', 'resourceInternalId',
'teamId', 'teamInternalId',
'country', 'region', 'hostname', 'ip',
'protocol', 'accept', 'acceptLanguage', 'cookie', 'queryKeys',
'protocol', 'accept', 'acceptLanguage', 'queryKeys',
'city', 'continentCode', 'subdivisions',
'postalCode', 'latitude', 'longitude', 'timeZone', 'weatherCode',
'isp', 'autonomousSystemNumber', 'autonomousSystemOrganization',
Expand Down
Loading