Skip to content

feat(metric): remove cookie column from request attributes in Metric … - #37

Merged
ArnabChatterjee20k merged 1 commit into
mainfrom
feat-new-usage-stats
Sep 3, 2026
Merged

ArnabChatterjee20k merged 1 commit into
mainfrom
feat-new-usage-stats

Conversation

@ArnabChatterjee20k

Copy link
Copy Markdown
Contributor

…class

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the cookie request attribute from the event metric contract and generated schema.

  • Updates the event-column allowlist and its documentation.
  • Removes the cookie column from event schema generation.
  • Updates the metric schema test expectation.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The removed dimension is updated consistently across the metric contract, generated schema, and tests, while existing database columns are tolerated by additive schema reconciliation.

Important Files Changed

Filename Overview
src/Usage/Metric.php Consistently removes cookie from the event dimension allowlist, documentation, and generated schema without disrupting existing schema reconciliation.
tests/Usage/MetricTest.php Updates the expected event-column list to reflect the intentional removal of cookie.

Reviews (1): Last reviewed commit: "feat(metric): remove cookie column from ..." | Re-trigger Greptile

@ArnabChatterjee20k
ArnabChatterjee20k merged commit 59f5b64 into main Sep 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants