Repository navigation
docs(agent): commit-hint gate is advisory, not the last gate (#4016) - #4024
Merged
Merged
Conversation
The detector's only recordStep call sat inside the no-tool-call branch, so its hasToolCall argument was constant false and the streak could never reach 4 - dead from birth. Detection now happens at the beginBatch boundary (structurally true); the no-tool branch keeps a pure streak-reset call. Source-level guard pins both wirings. Closes #4012 Co-Authored-By: ggcode <noreply@ggcode.dev>
Two same-shaped continue gates (doc-drift r465, draft-PR sa-223) can still fire after the commit hint by default configuration. The stale 'last gate' claim misled maintainers into wrong convergence assumptions - this area previously produced real bugs from exactly that (#3683). Closes #4016 Co-Authored-By: ggcode <noreply@ggcode.dev>
topcheer
pushed a commit
that referenced
this pull request
Oct 12, 2026
…(first-opened 05:44:25Z per pileup ruling) Co-Authored-By: ggcode <noreply@ggcode.dev>
Owner
Author
|
独立复核 GO 留痕（收口席·偶数域承接；approve 同账限制，以此评论为持久记录）： #4018（#4015 strategist 标记偏移）：indexFoldASCII 原串折叠扫描+stripStrategistCompleteMarker（保留原文大小写）+实证漂移族三测（ɐ+1B/ſ−1B/ı−1B，ß/fi 无漂移对照）——勘误链（dev 席 ToUpper 简单映射实证+本席双探针校核）已收编。CI 9/9 success。 #4024（#4016 commit-hint 注释失实+#4012 冗余半）：注释改"advisory，非 last gate"（doc-drift/draft-PR 两门仍可 fire）如实化；其携带之 #4012 hunks 与已并 #4019 逐字同文（main L3133-3137/3865 直证）——3-way 合并幂等归一，净变化仅 #4016 注释。CI 9/9 success。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题（#4016，P3 文档级）
L3608 注释宣称 commit-hint 是 "This is the last gate"，但默认配置下其后仍有 doc-drift（r465）与 draft-PR hint（sa-223）两个同形态 continue 门禁可能触发——注释-行为失配，且该区域曾因类似错误假设出过真 bug（#3683）。
修法
按立案修复要点：改为 advisory 语义+明确列举两个后随门禁（各 one-shot）。
纯注释修（+6/-4），零运行时影响。build ./... exit 0，vet 过。
Closes #4016