Skip to content

fix(cli): preserve endpoint API failure diagnostics - #537

Merged
blainekasten merged 2 commits into
mainfrom
cursor/cli-command-failure-analysis-3938
Aug 24, 2026
Merged

fix(cli): preserve endpoint API failure diagnostics#537
blainekasten merged 2 commits into
mainfrom
cursor/cli-command-failure-analysis-3938

Conversation

@cursor

@cursor cursor Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace controlled endpoint API sys.exit(1) paths with diagnostic-carrying exits
  • retain safe categorical reasons for endpoint-not-found, permission, and authentication failures in CLI telemetry
  • add focused coverage for all three handled API error classes

Evidence

The 2026-08-20 14:00–2026-08-21 14:00 UTC export contained 14 current-version endpoints list failures reported only as 1. The list command has no local status-1 path; these failures come from the shared endpoint API error decorator, which already prints a safe diagnosis but discarded it before telemetry capture. No open PR or main-branch fix covered this shared decorator.

Tests

  • endpoint and telemetry suites with Pydantic 2: 55 passed
  • endpoint and telemetry suites with Pydantic 1: 55 passed
  • Ruff lint and format checks
  • Pyright on changed files
Open in Web View Automation 

cursoragent and others added 2 commits August 21, 2026 14:07
Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@blainekasten
blainekasten marked this pull request as ready for review August 24, 2026 17:02
@blainekasten
blainekasten merged commit 49f368b into main Aug 24, 2026
11 of 12 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants