Skip to content

fix(cli): preserve endpoint creation diagnostics - #541

Merged
blainekasten merged 1 commit into
mainfrom
cursor/cli-command-failure-analysis-7d5d
Aug 24, 2026
Merged

fix(cli): preserve endpoint creation diagnostics#541
blainekasten merged 1 commit into
mainfrom
cursor/cli-command-failure-analysis-7d5d

Conversation

@cursor

@cursor cursor Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace endpoint creation's controlled sys.exit(1) paths with CliDiagnosticExit
  • retain safe categorical diagnostics for replica bounds, availability zones, hardware, and unavailable models
  • keep the existing user-visible guidance unchanged
  • add focused regression coverage for every converted path

Evidence

The 2026-08-22 14:00–2026-08-23 14:00 UTC export contained 175 CLI failures, 18 from version 2.31.0. Two current-version legacy endpoints create invocations were recorded only as 1; one omitted hardware and followed the command's existing guided failure path. #537 covers only the shared endpoint API decorator, so it does not duplicate these command-specific exits.

Tests

  • TOGETHER_TELEMETRY_DISABLED=1 python3 -m uv run pytest tests/unit/test_cli_endpoint_create.py tests/unit/test_cli_telemetry.py tests/cli/test_endpoints.py (57 passed)
  • focused endpoint diagnostic suite (5 passed)
  • Ruff check and format check
  • Pyright on changed files
  • mypy on the implementation
Open in Web View Automation 

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>
@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@blainekasten
blainekasten marked this pull request as ready for review August 24, 2026 16:56
@blainekasten
blainekasten merged commit a08d56c into main Aug 24, 2026
11 of 12 checks passed
@github-actions github-actions Bot mentioned this pull request Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants