CCM: Use existing metrics port (--secure-port) for SDK metrics instead of dedicated one (--metrics-address) - #1515
Conversation
ske-prow
Bot
added
kind/enhancement
aa4056f to
e1175bd
Compare
ske-prow
Bot
added
size/S
dergeberl
removed
the
breaking
| - containerPort: 10258 | ||
| hostPort: 10258 | ||
| name: https | ||
| protocol: TCP | ||
| - containerPort: 9090 | ||
| hostPort: 9090 | ||
| name: metrics | ||
| protocol: TCP |
There was a problem hiding this comment.
This whole thing is weird. It doesn't match what is in service.yaml
There was a problem hiding this comment.
You are right. Also the 8888 does not exist. I fixed the service.
|
LGTM label has been added. DetailsGit tree hash: 03d9381d222a7cdedc7f7c40f50ba5c2a8ba815c |
ske-prow
Bot
added
the
approved
|
/hold |
ske-prow
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
LGTM label has been added. DetailsGit tree hash: 4c6b0eb7951a482d77926bb0feee7b95c80d0592 |
ske-prow
Bot
removed
the
do-not-merge/hold
|
/cherry-pick release-v1.34 |
|
@dergeberl: new pull request created: #1525 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1526 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dergeberl: new pull request created: #1527 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
The CCM somehow has 2 metrics port.
--secure-portwhich also contains some metrics from the cloud-provider package and--metrics-addresswhich only contains the SDK metrics.This PR adds the SDK metrics to the metrics served with
--secure-port.--metrics-addressis still available and needs will be removed in the future.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
We also could still open the
--metrics-addressfor transition, instead of not using it directly.Breaking changes: