Adopt service to be able scrape from secure port in CCM - #260
Merged
Conversation
ske-prow
Bot
added
kind/enhancement
dergeberl
force-pushed
the
adoptCCMMetricsPort
branch
from
August 20, 2026 14:26
6d58e67 to
949dd8a
Compare
dergeberl
removed
the
do-not-merge/hold
nschad
approved these changes
Aug 21, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
Bot
added
lgtm
|
LGTM label has been added. DetailsGit tree hash: ae1b7e67f5faafa385c982cfbfee396b0ded2ec1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
/cc @stackitcloud/ske-infrastructure
What this PR does / why we need it:
Add already existing
--secure-portport to service and also allow scraping from it. Can old--metrics-addresscan be removed later when PR stackitcloud/cloud-provider-stackit#1515 is merged, released and updated in this repo.