Skip to content

use cortex-m-types in NVIC - #654

Open
robamu wants to merge 1 commit into
mainfrom
use-cortex-m-types-in-nvic
Open

robamu wants to merge 1 commit into
mainfrom
use-cortex-m-types-in-nvic

Conversation

@robamu

@robamu robamu commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor

The InterruptNumber blanket impl for cortex_m_types::InterruptNumber is not compatible with the one for all types implementing bare_metal::Nr . removing the other blanket impl is probably a breaking change? :/

Related to #183

@adamgreig

Copy link
Copy Markdown
Member

Hah, shame we can't add an impl of bare_metal's Nr to cortex-m-types. Can we keep using cortex-m's old InterruptNumber trait in NVIC, and add an impl of InterruptNumber for anything implementing either bare_metal's Nr or cortex-m-type's InterruptNumber?

@robamu

robamu commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor Author

maybe, but I do not know how with my current Rust foo. I get conflicting implementation errors when I try do add a blanket impl for both of these types. The fundamental problem probably is that this is a breaking change, right?

At this point I wonder whether we just have to accept some transition pain and move forward with the breaking change. then I have to merge into a different branch. At the very least, PACs will not break anymore in the future, as long as everybody agrees on the same trait crate, right?

@robamu

robamu commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor Author

do we have a branch for breaking changes? drafted until it is decided how to continue..

@robamu

robamu commented Apr 26, 2026

Copy link
Copy Markdown
Contributor Author

I think the current CI failure is fixed by #653

@robamu
robamu marked this pull request as draft April 26, 2026 12:37
@robamu
robamu marked this pull request as ready for review April 27, 2026 09:20
@robamu
robamu force-pushed the use-cortex-m-types-in-nvic branch from a64de05 to 1992346 Compare April 27, 2026 12:03
@robamu
robamu requested a review from Copilot April 27, 2026 14:36

This comment was marked as resolved.

@robamu
robamu force-pushed the use-cortex-m-types-in-nvic branch from 168018f to e827f54 Compare April 27, 2026 16:01
@robamu
robamu force-pushed the use-cortex-m-types-in-nvic branch from e827f54 to 5f443f7 Compare August 25, 2026 08:37
@robamu
robamu force-pushed the use-cortex-m-types-in-nvic branch 3 times, most recently from ef466e9 to a0fe2da Compare October 28, 2026 17:13
@robamu
robamu force-pushed the use-cortex-m-types-in-nvic branch from 8f3e1c1 to ba61633 Compare October 28, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants