Repository navigation
Conversation
robamu
changed the title
robamu
force-pushed
the
deprecate-old-interrupt-number
branch
3 times, most recently
from
October 28, 2026 17:33
cb63454 to
94f018a
Compare
robamu
force-pushed
the
deprecate-old-interrupt-number
branch
from
October 28, 2026 17:37
94f018a to
4580fec
Compare
- Mark the `interrupt::InterruptNumber` trait as deprecated to encourage PACs/HALs to switch to new trait - Remove `bare_metal::interrupt::Nr` blanket implementation to allow removal of the dependency - NVIC module still uses old trait to avoid breaking change - Add blanket implementation of trait for all implementors of new trait.
robamu
force-pushed
the
deprecate-old-interrupt-number
branch
from
October 28, 2026 17:40
4580fec to
27b89ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #654 which is less breaking. It is still a breaking change though.
interrupt::InterruptNumbertrait as deprecated to encourage PACs/HALs to switch to new traitbare_metal::interrupt::Nrblanket implementation to allow removal of the dependency