Add ConstRefCallback in use_take_shared_method#3066
Open
mini-1235 wants to merge 2 commits intoros2:rollingfrom
Open
Add ConstRefCallback in use_take_shared_method#3066mini-1235 wants to merge 2 commits intoros2:rollingfrom
use_take_shared_method#3066mini-1235 wants to merge 2 commits intoros2:rollingfrom
Conversation
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
fujitatomoya
approved these changes
Feb 17, 2026
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with green CI.
while the naming is a bit misleading, "take shared" is appropriate for any callback that doesn't require exclusive ownership, i think. and that includes both shared-pointer callbacks and const-reference callbacks.
Collaborator
|
Pulls: #3066 |
Contributor
Author
|
Let me try to rebase and see if it fixes the build failure |
Contributor
Author
I don't think this is related to this PR, right? |
Collaborator
|
Yup, let me re-run the CI. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to our discussion in https://discourse.openrobotics.org/t/performance-characteristics-subscription-callback-signatures-rmw-implementation-intra-process-communication-ipc/51454/7?u=mini-1235
it seems like
ConstRefCallbackis missing inuse_take_shared_method