Repository navigation
fix: remove duplicate proxy_read_timeout that crashes nginx on start - #34
Closed
ronibhakta1 wants to merge 1 commit into
Closed
ronibhakta1 wants to merge 1 commit into
ronibhakta1 wants to merge 1 commit into
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nginx fails to start:
"proxy_read_timeout" directive is duplicate in 20-speech-server.conf:80./synthesizeincludesproxy-pass.conf(which setsproxy_read_timeout 120s) and then sets300sagain in the same block. nginx rejects repeated directives in one block. The old container kept running an older config, so this only surfaced when the deploy recreated nginx, and the site went down.Change
proxy_read_timeoutfrom the sharedproxy-pass.confsnippet.120sinlocation /,300sin/synthesize. Effective values are unchanged.Verified
nginx -tinnginx:alpinewith the rendered template: fails onmainwith the error above, passes with this change.Follow-up worth considering: run this
nginx -tin CI so config errors are caught before deploy.