Repository navigation
ci: build image + validate nginx on PRs; fix duplicate proxy_read_timeout - #33
Merged
Merged
Conversation
ronibhakta1
force-pushed
the
ci/docker-build-check
branch
from
October 8, 2026 14:10
3f243b7 to
35c38b5
Compare
ronibhakta1
force-pushed
the
ci/docker-build-check
branch
from
October 8, 2026 14:19
35c38b5 to
1fe619e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`ci.yml` runs lint/format/mypy/pytest on PRs, but the Docker image is only built in `deploy.yml` after merge to `main`. A broken Dockerfile, `uv.lock` or missing file would only surface during deployment.
Change
New `build` job in `ci.yml`, `needs: test` (skipped if tests fail):
Nothing is pushed or deployed from PRs. To make the check blocking, mark `build` as a required status check in branch protection.
Not covered
Runtime behaviour of the image (model downloads, ffmpeg at runtime).
Added: nginx config check + the fix it caught
Renders
nginx/templatesand runsnginx -tinnginx:alpine(throwaway cert). It failed onmainwith"proxy_read_timeout" directive is duplicate— the cause of the prod nginx crash — so this PR also carries the fix (formerly #34):proxy_read_timeoutmoves from the shared snippet to per-location (120sin/,300sin/synthesize; effective values unchanged).