Skip to content

Update pyproject.toml to support building wheels for Python 3.14 #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhucka wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update pyproject.toml to support building wheels for Python 3.14 #1106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a1036a2
Update pyproject.toml to support Python 3.14
mhucka Sep 1, 2026
5a6c94b
Test with Python 3.14 in CI
mhucka Sep 1, 2026
c0868f7
Follow GCA advice to put extra index url back in overrides
mhucka Sep 2, 2026
7297654
Merge branch 'main' into add-py314
mhucka Sep 2, 2026
6407ae4
Move prefer_binary back into global cibuildwheel settings
mhucka Sep 2, 2026
7786c70
Skip manylinux_i686 per GCA suggestion
mhucka Sep 2, 2026
f449ba0
Move skip directive to the correct section
mhucka Sep 2, 2026
2ab841b
`skip` needs to be moved to the top-level linux section
mhucka Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ jobs:
- windows-2025-x64-8-core
python_version:
- '3.10'
- '3.13'
- '3.14'
steps:
- name: Check out a copy of the git repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
Expand Down
17 changes: 10 additions & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,18 +126,26 @@ dependencies = {file = ["requirements.txt"] }

[tool.cibuildwheel]
build = "cp310-* cp311-* cp312-* cp313-* cp314-*"
skip = ["*musllinux*", "*manylinux_i686*"]
dependency-versions = "latest"
enable = ["cpython-prerelease"]
environment.PIP_PREFER_BINARY = "1"
before-test = "pip install --group dev"
# import-mode=importlib prevents local source shadowing when importing qsimcirq.
test-command = "pytest --import-mode=importlib -n auto -s -v {package}/qsimcirq_tests/qsimcirq_test.py"

[tool.cibuildwheel.linux]
manylinux-x86_64-image = "manylinux2014"
manylinux-i686-image = "manylinux2014"
Comment on lines +137 to +139

@gemini-code-assist gemini-code-assist Bot Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The skip = "*musllinux*" setting was removed from the general [tool.cibuildwheel.linux] configuration during reorganization. This will cause cibuildwheel to attempt building musllinux wheels for all other Python versions (3.10 to 3.13), which is likely unintended. To restore this and also skip i686 for Python 3.14, configure skip globally under the Linux platform section.

Suggested change
[tool.cibuildwheel.linux]
manylinux-x86_64-image = "manylinux2014"
manylinux-i686-image = "manylinux2014"
[tool.cibuildwheel.linux]
manylinux-x86_64-image = "manylinux2014"
manylinux-i686-image = "manylinux2014"
skip = "*musllinux* cp314-manylinux_i686"


[[tool.cibuildwheel.overrides]]
# Help increase the chances that pip will find binary wheels for NumPy.
# See https://cibuildwheel.pypa.io/en/stable/faq/#building-with-numpy
# For Python 3.14, have to use a more recent manylinux image.
select = ["cp314*"]
inherit.environment = "append"
manylinux-x86_64-image = "manylinux_2_28"
manylinux-aarch64-image = "manylinux_2_28"
Comment thread
mhucka marked this conversation as resolved.
Comment thread
mhucka marked this conversation as resolved.
Comment thread
mhucka marked this conversation as resolved.
# Help increase the chances that pip will find binary wheels for NumPy.
# See https://cibuildwheel.pypa.io/en/stable/faq/#building-with-numpy
environment.PIP_EXTRA_INDEX_URL = "https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/"
environment.PIP_PRERELEASE = "allow"

Expand All @@ -154,11 +162,6 @@ delocate-listdeps {wheel} &&
delocate-wheel --verbose --require-archs {delocate_archs} -w {dest_dir} {wheel}
"""

[tool.cibuildwheel.linux]
manylinux-x86_64-image = "manylinux2014"
manylinux-i686-image = "manylinux2014"
skip = "*musllinux*"

[tool.black]
target-version = ['py310', 'py311', 'py312', 'py313', 'py314']
extend-exclude = 'third_party'
Expand Down
Loading