Update pyproject.toml to support building wheels for Python 3.14 - #1106
Update pyproject.toml to support building wheels for Python 3.14#1106mhucka wants to merge 8 commits into
pyproject.toml to support building wheels for Python 3.14#1106Conversation
Some adjustments were necessary to support building with Python 3.14.
pyproject.toml to support Python 3.14
pyproject.toml to support Python 3.14pyproject.toml to support building wheels for Python 3.14
There was a problem hiding this comment.
Code Review
This pull request reorganizes the cibuildwheel configuration in pyproject.toml, adding specific manylinux image overrides for Python 3.14 builds. The reviewer noted that moving PIP_EXTRA_INDEX_URL and PIP_PRERELEASE to the global environment affects all Python versions, which could cause stable Python builds to unexpectedly pull in unstable nightly dependencies. It is recommended to keep these settings restricted to the Python 3.14 override block.
|
/gemini review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the pyproject.toml configuration to use the newer manylinux_2_28 image for Python 3.14 builds on x86_64 and aarch64 architectures. The reviewer pointed out that since manylinux_2_28 does not support i686, the 32-bit build will fall back to manylinux2014 and likely fail due to glibc incompatibility. They recommended explicitly skipping i686 builds for Python 3.14.
|
/gemini review |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the cibuildwheel configuration in pyproject.toml to support Python 3.14. The reviewer identified that manylinux-*-image options cannot be overridden inside [[tool.cibuildwheel.overrides]] as it leads to a validation error. To address this, the reviewer recommends globally upgrading the Linux manylinux images to manylinux_2_28 and removing the invalid overrides.
This partly resolves #1017. This PR makes some adjustments to
pyproject.tomlto make building wheels on Python 3.14 actually work. This adjusts CI to test on Python 3.14 too.In addition, I also moved the settings around a little bit to group them in a (hopefully) more logical manner, and due to the need to make it pass validation, ended up moving the
skipproperty and thereby fixing #1084.