Skip to content

Fix(Core): Prevent error whit mising tools folder with official release #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebuzz merged 3 commits into from
Apr 30, 2026
Merged

Fix(Core): Prevent error whit mising tools folder with official release #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9037fe7
Fix(Core): Prevent error whit mising tools folder with official release
stonebuzz Apr 28, 2026
a938b64
Apply suggestion from @Rom1-B
Rom1-B Apr 29, 2026
6a3c1e2
Apply suggestions from code review
Rom1-B Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Jamf Plugin for GLPI Changelog

## [UNRELEASED]

### Fixed

- Fix failed to open stream: No such file or directory (`jamf/tools/pmv.json`)

## [3.2.0] - 2026-04-23
Comment thread
Rom1-B marked this conversation as resolved.

### Added
Expand Down
4 changes: 1 addition & 3 deletions inc/migration.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,9 +618,7 @@ public function apply_3_0_0_migration(): void
// Copy default pmv from tools dir
$pmv_file_path = GLPI_PLUGIN_DOC_DIR . '/jamf/pmv.json';
if (!file_exists($pmv_file_path)) {
Toolbox::logDebug($pmv_file_path);
Toolbox::logDebug(Plugin::getPhpDir('jamf') . '/tools/pmv.json');
copy(Plugin::getPhpDir('jamf') . '/tools/pmv.json', $pmv_file_path);
copy(Plugin::getPhpDir('jamf') . '/resources/pmv.json', $pmv_file_path);
}

// Register Cron task to update PMV periodically
Expand Down
0 tools/pmv.json → resources/pmv.json
View file
Open in desktop
File renamed without changes.