Skip to content

Fix(Core): Prevent error whit mising tools folder with official release#32

Merged
stonebuzz merged 3 commits intomainfrom
fix_pvm_json_handling
Apr 30, 2026
Merged

Fix(Core): Prevent error whit mising tools folder with official release#32
stonebuzz merged 3 commits intomainfrom
fix_pvm_json_handling

Conversation

@stonebuzz
Copy link
Copy Markdown

@stonebuzz stonebuzz commented Apr 28, 2026

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !43671

Prevent error during isntallation

With official release tools folder not exist

glpi.WARNING:   *** Warning: copy(./marketplace/jamf/tools/pmv.json): Failed to open stream: No such file or directory at filesystem.php line 114
  Backtrace :
  ...ngmachine/safe/generated/8.3/filesystem.php:114 
  ./marketplace/jamf/inc/migration.class.php:623     Safe\copy()
  ./marketplace/jamf/inc/migration.class.php:102     PluginJamfMigration->apply_3_0_0_migration()
  ./marketplace/jamf/hook.php:37                     PluginJamfMigration->applyMigrations()
  ./src/Plugin.php:1249                              plugin_jamf_install()
  :                                                  Plugin->install()
  ./src/Glpi/Marketplace/Controller.php:684          call_user_func()
  ./src/Glpi/Marketplace/Controller.php:574          Glpi\Marketplace\Controller->setPluginState()
  ./ajax/marketplace.php:62                          Glpi\Marketplace\Controller->installPlugin()
  ...Glpi/Controller/LegacyFileLoadController.php:64 require()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:208        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:71                              Symfony\Component\HttpKernel\Kernel->handle()
glpi.CRITICAL:   *** Uncaught PHP Exception Safe\Exceptions\FilesystemException: "An error occurred" at FilesystemException.php line 9
  Backtrace :
  .../generated/Exceptions/FilesystemException.php:9 
  ...ngmachine/safe/generated/8.3/filesystem.php:117 Safe\Exceptions\FilesystemException::createFromPhpError()
  ./marketplace/jamf/inc/migration.class.php:623     Safe\copy()
  ./marketplace/jamf/inc/migration.class.php:102     PluginJamfMigration->apply_3_0_0_migration()
  ./marketplace/jamf/hook.php:37                     PluginJamfMigration->applyMigrations()
  ./src/Plugin.php:1249                              plugin_jamf_install()
  :                                                  Plugin->install()
  ./src/Glpi/Marketplace/Controller.php:684          call_user_func()
  ./src/Glpi/Marketplace/Controller.php:574          Glpi\Marketplace\Controller->setPluginState()
  ./ajax/marketplace.php:62                          Glpi\Marketplace\Controller->installPlugin()
  ...Glpi/Controller/LegacyFileLoadController.php:64 require()
  ./vendor/symfony/http-kernel/HttpKernel.php:181    Glpi\Controller\LegacyFileLoadController->__invoke()
  ./vendor/symfony/http-kernel/HttpKernel.php:76     Symfony\Component\HttpKernel\HttpKernel->handleRaw()
  ./vendor/symfony/http-kernel/Kernel.php:208        Symfony\Component\HttpKernel\HttpKernel->handle()
  ./public/index.php:71                              Symfony\Component\HttpKernel\Kernel->handle()

Screenshots (if appropriate):

@stonebuzz stonebuzz self-assigned this Apr 28, 2026
@stonebuzz stonebuzz added the bug Something isn't working label Apr 28, 2026
@stonebuzz stonebuzz requested a review from Rom1-B April 28, 2026 14:08
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@stonebuzz stonebuzz merged commit 757400f into main Apr 30, 2026
3 checks passed
@stonebuzz stonebuzz deleted the fix_pvm_json_handling branch April 30, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants