i18n(ja): restore 4-word and 3-word TiDB Cloud UI labels to English - #23519
Draft
yahonda wants to merge 23 commits into
Draft
i18n(ja): restore 4-word and 3-word TiDB Cloud UI labels to English#23519yahonda wants to merge 23 commits into
yahonda wants to merge 23 commits into
Conversation
Many bold-wrapped TiDB Cloud web console UI labels (button/tab/field/page names) were translated into Japanese instead of being kept in English, inconsistent with how UI strings are usually handled elsewhere in the ja docs (see maintainer guidance in pingcap#23455 (comment)). This restores 467 target 4-word and 3-word UI labels (977 occurrences) across 135 tidb-cloud/ files (excluding releases/) back to English, using EN/JA bold-span positional pairing per file, limited to files where EN and JA bold-span counts matched exactly. Also fixes several pre-existing MT defects surfaced while auditing the mechanical fix: stray leftover decoration characters (「」[]) left over from imprecise bold-span capture, a word-order swap between EN and JA labels, dropped particles, and one case where the JA bold span covered far more text than the actual label, causing content loss. 11 files with mismatched EN/JA bold-span counts were intentionally skipped and are left for a separate pass. A corpus-wide scan for "straddling bracket" defects (decoration characters split across the wrong side of ** markers) on the touched files found 133 additional candidates, all single-word labels out of this batch's scope; logged for a future 1-word/2-word batch, not fixed here.
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
the
do-not-merge/work-in-progress
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
missing-translation-status
…hrase, not a UI label
…names
The 3/4-word UI-label restoration mechanically treated the literal
Hugo template placeholders {{{ .premium }}} and {{{ .dedicated }}},
as captured from the EN bold span content at those exact positions,
as English UI labels and inserted them verbatim into JA prose,
overwriting the correctly hardcoded product names and, in three
spots, dropping the trailing particle that used to sit inside the
old bold span.
…um/Dedicated in the provider bullet list
…icle in IP access list steps
…t Minimum Billing RCU to its translated term
…fied against dbaas-ui source
Audited the part-1 batch (26 files) against the actual TiDB Cloud
console source (tidbcloud/dbaas-ui) to tell literal UI strings apart
from descriptive/marketing prose that EN happens to bold.
Reverted to Japanese where the label is not confirmed literal UI text
(architecture-concepts.md marketing bullets, RU cost-factor headers,
branch/backup/configure-external-storage descriptive headers, etc).
Kept/restored to English where dbaas-ui confirms the exact string is
rendered in the console, including two cases that are dynamically
built from field identifiers rather than literal string constants
(Ignore insert/delete value expression, built via
capitalize(id.replace('_',' ').replace('expr','expression')) in
EventFilter.tsx) and were therefore missed by a naive grep.
…resume, Alibaba/Azure Kafka private-link, and premium encryption docs
Partial audit work from a session that hit its token limit mid-run.
Verified the remaining calls before committing: TiDB Cloud's own pause/resume
dialog title is dynamically 'Pause/Resume {cluster name} cluster', not the
literal 'Pause your cluster' the EN doc bolds, so Japanese is kept. Third-party
AWS/Azure/Alibaba console field names are not in dbaas-ui (TiDB Cloud's own
frontend) by definition; kept the ones that are well-established, stable
console conventions in English and reverted documentation-only category
headers (grouping several real fields under one bold label) to Japanese.
…fied against dbaas-ui source and EN parity Audited the part-2 batch (26 files: data-service, import, integrate-*, manage-* docs) against tidbcloud/dbaas-ui and, for third-party consoles (AWS/Vercel/Zapier/n8n/Airbyte/Postman), general knowledge of their stable UI conventions. Reverted marketing/prose bullets and doc-only category headers that aren't literal console strings. Corrected a few spans where the mechanical pass had picked the wrong adjacent English phrase for the position (e.g. data-service-manage-github-connection.md's Connect/ Disconnect toggle button was mislabeled 'Connect to GitHub', which is actually the area title, not the button — confirmed 1:1 against the EN source's own 'click **Connect** in the **Connect to GitHub** area' phrasing).
…grate/monitor/oauth docs, verified against dbaas-ui Audited the part-3 batch (21 files: migrate-*, monitor-*, oauth2, premium auditing/export/import docs) against tidbcloud/dbaas-ui and, for third-party consoles (AWS DMS/IAM, PagerDuty, Slack, Datadog, New Relic, Alibaba RAM), general knowledge of their stable UI conventions. Reverted doc-only category headers and unconfirmed spans. Fixed a few cases where the mechanical pass had scrambled which English label landed on which position (Datadog/New Relic/Delete mismap in migrate-metrics-integrations.md; Add Filter Rule/Log Filter Rules swap in premium/tidb-cloud-auditing-premium.md). Kept dbaas-ui's exact wording only for confirming whether a span is a genuine UI label at all; where dbaas-ui's current literal text differs from what the EN doc itself bolds (e.g. EN bolds 'Choose migration job type' but the current console tab is labeled 'Migration Type'), mirrored the EN doc's own wording rather than substitute newer UI copy EN doesn't use — this stays a ja-only sync fix, not an EN-side accuracy correction.
…curity/recovery-group/private-link/auditing docs Audited the part-4 batch (27 files: security-concepts, recovery-group-*, serverless private-link setup across AWS/Azure/GCP/Alibaba, TiDB Cloud auditing) against tidbcloud/dbaas-ui and third-party console knowledge. security-concepts.md is fully conceptual/architectural prose (IAM, projects, encryption overview) with no console walkthrough — reverted in full, now byte-identical to the pre-automation original. Fixed word-order/mapping bugs the mechanical pass introduced in tidb-cloud-auditing(-legacy).md: Log Filter Rules/Add Filter Rule and Database Audit Logging/Audit Log Access had been swapped onto the wrong bold spans; corrected to match EN's own step-by-step order.
…ns, verified against dbaas-ui source Audited the part-5 batch (27 files: billing, budget, clinic, DMS/DM, console-auditing, import, log-redaction, SSO auth, PoC, quickstart, roadmap, support, TLS connect, node-group management, TiDB X architecture/intro, tiproxy, top-ru, chat2query docs) against tidbcloud/dbaas-ui and third-party console knowledge. Reverted marketing/architecture-whitepaper prose (tidb-x-architecture.md, tidb-cloud-intro.md, v8.5-performance-highlights.md are almost entirely descriptive, not console walkthroughs) and fixed a couple of field/button mapping swaps (use-chat2query-api.md, tidb-node-group-management.md). Restored 'Sign in with Google/GitHub/Microsoft' to English rather than reverting to Japanese: dbaas-ui shows these buttons were renamed to 'Continue with X', but EN's own doc text still says 'Sign in with X' — per the established rule, ja mirrors EN's own wording exactly; EN's staleness relative to the live console is a separate, EN-side concern out of scope for a ja-only sync fix.
…-3 field labels Fixed missing を particle after `No` in Automatically Accept Endpoint Connections steps (2 files), and translated the broker-3 Network and Zone / Instance and Image field labels that were left in English while their broker-1/broker-2 siblings in the same file were already correctly translated.
…c, matching its sibling docs
…hing legacy and premium siblings
…across PR pingcap#23519's changed lines Scoped sweep: checked every line changed by the 3/4-word UI-label restoration batch (git diff fcd3ad0) for **「English label」** where EN's own doc has no quote decoration, restricted to lines the batch actually touched (not a blind corpus-wide strip, since 「」 around Japanese-language UI references elsewhere is often legitimate). 24 sites across 15 files: Amazon S3, Alibaba Cloud OSS, Failover, Add Credit Card, Add a Card, Add a New Card, Create Custom Budget, Add alert threshold., Continue with TiDB Account, Upload a local file, Set Up Authenticator App, Talk to an expert, show example usage (x4), TiDB Node Group, Chat2Query Data App, Create API Key (x2), Show Code Example (x2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
TiDB Cloud web console UI labels (button/tab/field/page names, wrapped in
**...**) were translated into Japanese instead of being kept in English, inconsistent with how UI strings are usually handled elsewhere in the ja docs. See maintainer guidance: #23455 (comment)This PR restores 4-word and 3-word TiDB Cloud UI labels across
tidb-cloud/(excludingreleases/) back to English, using EN/JA bold-span positional pairing per file, limited to files where EN and JA bold-span counts matched exactly.A conservative verification pass was then run over every touched file, checking each restored label against the actual TiDB Cloud console frontend source (a private repo the reviewer made available for this purpose) to confirm it is genuinely a literal UI string, not just a descriptive/emphasis phrase EN happens to bold. Spans that could not be confirmed as literal UI text were reverted back to their original Japanese wording. Third-party console labels (AWS/Azure/Alibaba Cloud/GCP/PagerDuty/Slack/Datadog/New Relic/Airbyte/n8n/Vercel/Zapier, etc.) were judged on general knowledge of those stable, well-known UI conventions, since they aren't in the TiDB Cloud frontend source.
Along the way this also fixed several pre-existing MT defects surfaced during the audit:
「」[]) split across the wrong side of**bold markers ("straddling bracket" defect){{{ .premium }}}etc.) that leaked into JA prose in place of the resolved product name, in a file where the JA translation otherwise never uses templatesWhere the actual current console text has drifted from what the EN documentation itself bolds (e.g. a button since renamed), the JA translation mirrors EN's own wording — that mismatch is an EN-doc staleness issue, out of scope for a ja-only sync PR.
Note for reviewers: files with mismatched EN/JA bold-span counts were intentionally skipped and are left for a separate pass. A corpus-wide scan for "straddling bracket" defects on the touched files found more candidates, all single-word labels out of this batch's scope; logged for a future 1-word/2-word batch, not fixed here.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?