Skip to content

PHP json_encode(): Check depth range before narrowing #23589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuishuang wants to merge 2 commits into
base: master
Choose a base branch
from
+24 −0
Open

PHP json_encode(): Check depth range before narrowing #23589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8047d9
PHP json_encode(): Check depth range before narrowing
cuishuang Sep 6, 2026
72bbf0d
Improve json_encode() depth test
cuishuang Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/json/json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,11 @@ PHP_FUNCTION(json_encode)
Z_PARAM_LONG(depth)
ZEND_PARSE_PARAMETERS_END();

if (ZEND_LONG_EXCEEDS_INT(depth)) {
zend_argument_value_error(3, "must be between %d and %d", INT_MIN, INT_MAX);
RETURN_THROWS();
}

php_json_encode_init(&encoder);
encoder.max_depth = (int)depth;
php_json_encode_zval(&buf, parameter, (int)options, &encoder);
Expand Down
19 changes: 19 additions & 0 deletions ext/json/tests/json_encode_depth.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
json_encode() rejects depth values outside the encoder range
--SKIPIF--
<?php if (PHP_INT_SIZE != 8) die("skip this test is for 64bit platform only"); ?>
--FILE--
<?php

foreach ([2147483648, -2147483649] as $depth) {
try {
json_encode([], depth: $depth);
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}
}

?>
--EXPECT--
ValueError: json_encode(): Argument #3 ($depth) must be between -2147483648 and 2147483647
ValueError: json_encode(): Argument #3 ($depth) must be between -2147483648 and 2147483647
Loading