PHP json_encode(): Check depth range before narrowing - #23589
Open
cuishuang wants to merge 2 commits into
Open
Conversation
NickSdot
reviewed
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json_encode()accepts$depthas azend_long, but stores it directly in the encoder'sint max_depthfield.On 64-bit builds, values outside the range of
intwere silently narrowed before encoding. This could produce platform-dependent behavior.Check the value with
ZEND_LONG_EXCEEDS_INT()before assigning it toencoder.max_depth, and throw aValueErrorwhen it cannot be represented as anint.Values within the existing range, including
depth == 0and negative values, retain their current behavior.The regression test covers values above
INT_MAXand belowINT_MIN.