SRVOCF-1040: replace undefined test helpers in setup guide test from PR #143 - #168
Conversation
…hift#143 The test added in PR openshift#143 called renderAuthenticated, setupBackendListAPIResponse, listItem, mockUseCluster, clusterData, and clusterFunction - none of which exist in this file or are imported. Replace with the stub-based pattern used by every other test in FunctionsListPage.test.tsx. Signed-off-by: Pedro Almeida <pealmeid@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@pmeida: This pull request references SRVOCF-1040 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
/lgtm |
|
/approve |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cragsmann, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
The test
renders the setup guide button in the list descriptioncalled six helpers that do not exist in the file and were never imported:renderAuthenticated,setupBackendListAPIResponse,listItem,mockUseCluster,clusterData, andclusterFunction. These appear to be leftover references from an older test API that was replaced before the PR landed.Replace them with
listFunctionsStuband the standard render pattern used by every other test inFunctionsListPage.test.tsx.Checklist
docs/ARCHITECTURE.md(if there are relevant changes to our layered architecture)