Skip to content

SRVOCF-1040: replace undefined test helpers in setup guide test from PR #143 - #168

Merged
Cragsmann merged 1 commit into
openshift:masterfrom
pmeida:fix/broken-test-refs-from-pr-143
Aug 26, 2026
Merged

SRVOCF-1040: replace undefined test helpers in setup guide test from PR #143#168
Cragsmann merged 1 commit into
openshift:masterfrom
pmeida:fix/broken-test-refs-from-pr-143

Conversation

@pmeida

@pmeida pmeida commented Aug 26, 2026

Copy link
Copy Markdown

Summary

The test renders the setup guide button in the list description called six helpers that do not exist in the file and were never imported: renderAuthenticated, setupBackendListAPIResponse, listItem, mockUseCluster, clusterData, and clusterFunction. These appear to be leftover references from an older test API that was replaced before the PR landed.

Replace them with listFunctionsStub and the standard render pattern used by every other test in FunctionsListPage.test.tsx.

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

…hift#143

The test added in PR openshift#143 called renderAuthenticated, setupBackendListAPIResponse,
listItem, mockUseCluster, clusterData, and clusterFunction - none of which exist
in this file or are imported. Replace with the stub-based pattern used by every
other test in FunctionsListPage.test.tsx.

Signed-off-by: Pedro Almeida <pealmeid@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 26, 2026

Copy link
Copy Markdown

@pmeida: This pull request references SRVOCF-1040 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

The test renders the setup guide button in the list description called six helpers that do not exist in the file and were never imported: renderAuthenticated, setupBackendListAPIResponse, listItem, mockUseCluster, clusterData, and clusterFunction. These appear to be leftover references from an older test API that was replaced before the PR landed.

Replace them with listFunctionsStub and the standard render pattern used by every other test in FunctionsListPage.test.tsx.

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@twoGiants

Copy link
Copy Markdown

/approve
/lgtm

@Cragsmann

Copy link
Copy Markdown

/lgtm

@Cragsmann

Copy link
Copy Markdown

/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cragsmann, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Cragsmann,twoGiants]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@Cragsmann
Cragsmann merged commit eee18e6 into openshift:master Aug 26, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants