Skip to content

SRVOCF-1056: add darwin to yarnrc supportedArchitectures for local macOS dev - #167

Closed
pmeida wants to merge 1 commit into
openshift:masterfrom
pmeida:SRVOCF-1056-add-darwin-to-yarnrc
Closed

SRVOCF-1056: add darwin to yarnrc supportedArchitectures for local macOS dev#167
pmeida wants to merge 1 commit into
openshift:masterfrom
pmeida:SRVOCF-1056-add-darwin-to-yarnrc

Conversation

@pmeida

@pmeida pmeida commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • Adds darwin to supportedArchitectures.os in .yarnrc.yml so that yarn install --immutable fetches darwin-arm64 native bindings on macOS
  • Fixes yarn test startup failure ("Cannot find native binding") on macOS caused by missing @rolldown/binding-darwin-arm64 and related packages
  • The Konflux hermetic build runs on linux only and is unaffected

Fixes SRVOCF-1056

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)

Resolves SRVOCF-1056. yarn install --immutable was skipping darwin-arm64
native bindings (rolldown, swc, lightningcss, fsevents) because only linux
was listed in supportedArchitectures.os, causing yarn test to fail with
"Cannot find native binding" on macOS. The Konflux hermetic build is linux-
only and unaffected by this change.

Signed-off-by: Pedro Almeida <pealmeid@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@pmeida pmeida changed the title fix: add darwin to yarnrc supportedArchitectures for local macOS dev SRVOCF-1056: add darwin to yarnrc supportedArchitectures for local macOS dev Aug 26, 2026
@openshift-ci
openshift-ci Bot requested review from Cragsmann and matejvasek August 26, 2026 07:57
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 26, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 26, 2026

Copy link
Copy Markdown

@pmeida: This pull request references SRVOCF-1056 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • Adds darwin to supportedArchitectures.os in .yarnrc.yml so that yarn install --immutable fetches darwin-arm64 native bindings on macOS
  • Fixes yarn test startup failure ("Cannot find native binding") on macOS caused by missing @rolldown/binding-darwin-arm64 and related packages
  • The Konflux hermetic build runs on linux only and is unaffected

Jira

SRVOCF-1056

Test plan

  • Run yarn install --immutable on macOS darwin-arm64 - no YN0077 warnings for darwin packages
  • Run yarn test on macOS darwin-arm64 - starts without "Cannot find native binding" error
  • Verify Konflux on-pull CI passes (linux build unaffected)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmeida

pmeida commented Aug 26, 2026

Copy link
Copy Markdown
Author

/hold

Depends on #168 to fix broken references - this will fix CI

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2026
@Cragsmann

Copy link
Copy Markdown

/retest

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

@pmeida: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pmeida

pmeida commented Aug 26, 2026

Copy link
Copy Markdown
Author

/retest faas-console-plugin-on-pull-request
/retest faas-console-plugin

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

@pmeida: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws
/test images
/test lint
/test unit

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-faas-console-plugin-master-images
pull-ci-openshift-faas-console-plugin-master-lint
pull-ci-openshift-faas-console-plugin-master-unit
Details

In response to this:

/retest faas-console-plugin-on-pull-request
/retest faas-console-plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmeida

pmeida commented Aug 26, 2026

Copy link
Copy Markdown
Author

opening a new one

@pmeida pmeida closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants