SRVOCF-1056: add darwin to yarnrc supportedArchitectures for local macOS dev - #167
SRVOCF-1056: add darwin to yarnrc supportedArchitectures for local macOS dev#167pmeida wants to merge 1 commit into
Conversation
Resolves SRVOCF-1056. yarn install --immutable was skipping darwin-arm64 native bindings (rolldown, swc, lightningcss, fsevents) because only linux was listed in supportedArchitectures.os, causing yarn test to fail with "Cannot find native binding" on macOS. The Konflux hermetic build is linux- only and unaffected by this change. Signed-off-by: Pedro Almeida <pealmeid@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@pmeida: This pull request references SRVOCF-1056 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold Depends on #168 to fix broken references - this will fix CI |
|
/retest |
|
@pmeida: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest faas-console-plugin-on-pull-request |
|
@pmeida: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
opening a new one |
Summary
darwintosupportedArchitectures.osin.yarnrc.ymlso thatyarn install --immutablefetches darwin-arm64 native bindings on macOSyarn teststartup failure ("Cannot find native binding") on macOS caused by missing@rolldown/binding-darwin-arm64and related packagesFixes SRVOCF-1056
Checklist
docs/ARCHITECTURE.md(if there are relevant changes to our layered architecture)