[ENH] V1 → V2 API Migration - core structure#1576
[ENH] V1 → V2 API Migration - core structure#1576geetu040 wants to merge 183 commits intoopenml:mainfrom
Conversation
…into issue1564
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
- Coverage 52.82% 52.65% -0.18%
==========================================
Files 37 61 +24
Lines 4371 5029 +658
==========================================
+ Hits 2309 2648 +339
- Misses 2062 2381 +319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Notes for stacked PRs on updating tests Please follow tests/test_api/test_versions.py to write tests. I have created fixtures in
FYI: @EmanAbdelhaleem @JATAYU000 @rohansen856 @satvshr @Omswastik-11 |
|
updated for #1611 (comment), #1609 (comment) |
geetu040
left a comment
There was a problem hiding this comment.
I have addressed all previous review comments from Pieter, Matthias, and co-pilot. Any remaining unresolved threads include a reply from my side and may need further discussion, please take a look and resolve if appropriate.
This PR is now stacked on #1577, which refactors config.py into _config.py.
I have made the following changes in the _config.py
- Removed
serverandapikeyas standalone config fields. - Introduced:
servers: holdsserverandapikeyper API version.api_version: active API version (also the switch point).fallback_api_version: optional fallback version (defaults toNone).serverandapikeyremain available via getters/setters, backed byservers+api_version.
- Removed the separate config used by the
_apimodule. It now relies directly on_config.py. - Added
SERVERS_REGISTRYto_config.pyto centralize environment configuration instead of scattering it across the SDK.
Updated all new API tests:
- Dropped
TestBaseinheritance. - Removed
TestAPIBase. - Converted everything to pure pytest style, creating and using fixtures from
conftest.py.
This PR is up for review but I'll continue addressing feedback from the stacked PRs and update this PR accordingly if needed.
FYI: @fkiraly @mfeurer @PGijsbers
Towards #1575
This PR sets up the core folder and file structure along with base scaffolding for the API v1 → v2 migration.
It includes:
*V1,*V2)No functional endpoints are migrated yet. This PR establishes a stable foundation for subsequent migration and refactor work.