[ENH] V1 → V2 API Migration - studies#1610
Draft
rohansen856 wants to merge 219 commits intoopenml:mainfrom
Draft
[ENH] V1 → V2 API Migration - studies#1610rohansen856 wants to merge 219 commits intoopenml:mainfrom
rohansen856 wants to merge 219 commits intoopenml:mainfrom
Conversation
…into issue1564
Signed-off-by: rohansen856 <rohansen856@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
==========================================
- Coverage 53.08% 51.99% -1.10%
==========================================
Files 36 61 +25
Lines 4357 5037 +680
==========================================
+ Hits 2313 2619 +306
- Misses 2044 2418 +374 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Implementing def _check_fold_timing_evaluations( # noqa: PLR0913
self,
fold_evaluations: dict[str, dict[int, dict[int, float]]],
num_repeats: int,
num_folds: int,
*,
max_time_allowed: float = 60000.0,
task_type: TaskType = TaskType.SUPERVISED_CLASSIFICATION,
check_scores: bool = True,
) -> None:Final function signature: def list( # noqa: PLR0913
self,
limit: int | None = None,
offset: int | None = None,
status: str | None = None,
main_entity_type: str | None = None,
uploader: list[int] | None = None,
benchmark_suite: int | None = None,
) -> Any: |
geetu040
suggested changes
Feb 25, 2026
Collaborator
geetu040
left a comment
There was a problem hiding this comment.
please sync with base PR and update with these comments #1576 (comment)
Signed-off-by: rohansen856 <rohansen856@gmail.com>
…into studies-migration
…enml-python into studies-migration
Signed-off-by: rohansen856 <rohansen856@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
Stackend PR, Depends on #1576
This PR adds
Studies v2migration.A question:
Due to the pre commit hook i could not put 6 arguments in a function, so i had to workaround that with this instead:
openml_api\resources\studies.py (line 10-15)
I would like to confirm if this approach is correct or not. Raising a draft PR for now.