fix(ui): keep moved-line colors on wrapped diff rows - #812
Merged
Conversation
Moved-line coloring never reached anyone with `wrap_lines = true`. Rows have two paint paths, and only the unwrapped one forwarded the move classification to the palette: the wrapped cell builders called `splitCellPalette`/`stackCellPalette` without the `moveKind` argument, so every moved row fell back to the ordinary added or removed tint. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
PR author is not in the allowed authors list. |
|
@HackAttack is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
benvinegar
approved these changes
Aug 25, 2026
Member
There was a problem hiding this comment.
Confirmed the bug locally: moved lines use the correct tint with wrapping off, but fall back to the normal added/removed colors when wrapping is enabled.
This fixes both the stack and split rendering paths. I also verified that the regression tests fail against the old implementation and pass with this change, including after merging into the latest main. Looks good to me.
Tiny non-blocking nit: the changeset says color.moved, but Git calls this diff.colorMoved / --color-moved.
This comment was generated by Pi using gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved-line coloring never reached anyone with
wrap_lines = true. Rows have two paint paths, and only the unwrapped one forwarded the move classification to the palette: the wrapped cell builders calledsplitCellPalette/stackCellPalettewithout themoveKindargument, so every moved row fell back to the ordinary added or removed tint.