Skip to content

Bug fixes for e2e tests #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
04diiguyi merged 3 commits into from
Mar 31, 2026
+8 −12
Merged

Bug fixes for e2e tests #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
789e161
Switch to 1e-2 in qiskit job's draw random sample to normilize probab…
rigidit Mar 30, 2026
0615510
Surface error when getting job results in cirq run
rigidit Mar 31, 2026
f1c544c
Remove not needed comments
rigidit Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions azure-quantum/azure/quantum/cirq/service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,17 +259,13 @@ def run(
target_obj = self.get_target(name=target)

# For SDK Cirq job wrappers, Job.results() already returns a Cirq result.
try:
from azure.quantum.cirq.job import Job as CirqJob

if isinstance(job, CirqJob):
return job.results(
timeout_seconds=timeout_seconds,
param_resolver=param_resolver,
seed=seed,
)
except Exception:
pass
from azure.quantum.cirq.job import Job as CirqJob
if isinstance(job, CirqJob):
return job.results(
timeout_seconds=timeout_seconds,
param_resolver=param_resolver,
seed=seed,
)

# Otherwise, preserve provider-specific behavior (e.g., cirq_ionq.Job).
try:
Expand Down
2 changes: 1 addition & 1 deletion azure-quantum/azure/quantum/qiskit/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def _format_results(
def _draw_random_sample(self, sampler_seed, probabilities, shots):
_norm = sum(probabilities.values())
if _norm != 1:
if np.isclose(_norm, 1.0, rtol=1e-4):
if np.isclose(_norm, 1.0, atol=1e-2):
probabilities = {k: v / _norm for k, v in probabilities.items()}
else:
raise ValueError(f"Probabilities do not add up to 1: {probabilities}")
Expand Down