Merged
Conversation
…ilities rather than raising an error
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
04diiguyi
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is e2e test failing with
ValueError: Probabilities do not add up to 1: defaultdict(<class 'int'>, {'0': 0.4991999864578247, '1': 0.4991999864578247})that tests qiskit submission to ionq. To fix the test, we switch to 1e-2 in qiskit job's draw_random_sample to allow probability sums in the range [0.99, 1.01] to be normalized rather than raising an error.Another e2e test failed when testing cirq.Circuit program run against quantinuum target, which caused by exception swallowed in first
job.resultscall insiderunmethod, and the fallback path then callsjob.resultson the same CirqJob again this time successfully and internally already returns a fully-convertedcirq.ResultDict, but ater that there istarget_obj._to_cirq_resultcall for the result and it fails wihAttributeError: 'ResultDict' object has no attribute 'items'. To fix this one we surface error for the CirqJob path immediately instead of silently falling into the wrong code path.