Skip to content

Fix type confusion in Serializer.getSerializerRegistration #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riccardobl merged 4 commits into from
Mar 22, 2026
+2 −2
Merged

Fix type confusion in Serializer.getSerializerRegistration #2604

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28431d3
Initial plan
Copilot Feb 11, 2026
a1496fa
Fix: Use java.io.Serializable.class instead of Serializable.class on …
Copilot Feb 11, 2026
9f33706
give precedence to type specific serializers over java.io.Serializable
riccardobl Mar 22, 2026
9c51e98
revert previous commit and skip serializer registrations for java.io.…
riccardobl Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jme3-networking/src/main/java/com/jme3/network/serializing/Serializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,13 +347,13 @@ public static SerializerRegistration getSerializerRegistration(Class cls, boolea
if (reg != null) return reg;

for (Map.Entry<Class, SerializerRegistration> entry : classRegistrations.entrySet()) {
if (entry.getKey().isAssignableFrom(Serializable.class)) continue;
if (entry.getKey().isAssignableFrom(java.io.Serializable.class)) continue;
if (entry.getKey().isAssignableFrom(cls)) return entry.getValue();
}

if (cls.isArray()) return registerClass(cls, arraySerializer);

if (Serializable.class.isAssignableFrom(cls)) {
if (java.io.Serializable.class.isAssignableFrom(cls)) {
return getExactSerializerRegistration(java.io.Serializable.class);
}

Expand Down
Loading