Fix path problem locations in .expected for 8-1-1, 8-1-2#1057
Open
MichaelRFairhurst wants to merge 3 commits intomainfrom
Open
Fix path problem locations in .expected for 8-1-1, 8-1-2#1057MichaelRFairhurst wants to merge 3 commits intomainfrom
MichaelRFairhurst wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes path problem locations in the .expected test result files for MISRA rules 8-1-1 and 8-1-2. The changes replace absolute paths to external standard library implementations with local test file paths, improving test stability across different compilers and environments.
Changes:
- Added local implementations of
std::forwardandstd::functionin both test files to ensure all path problem nodes and edges reference local paths - Updated all
.expectedfile entries to reference the new local paths instead of external standard library paths - Adjusted line numbers throughout the
.expectedfiles to account for the 35 new lines added at the beginning of each test file
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/misra/test/rules/RULE-8-1-2/test.cpp | Added local std utilities implementation (lines 1-35) with documentation explaining the approach |
| cpp/misra/test/rules/RULE-8-1-2/ImplicitCapturesDisallowedInNonTransientLambda.expected | Updated all path references from external library to local test file and adjusted line numbers for 23 query results |
| cpp/misra/test/rules/RULE-8-1-1/test.cpp | Added identical local std utilities implementation (lines 1-35) as in RULE-8-1-2 |
| cpp/misra/test/rules/RULE-8-1-1/NonTransientLambdaImplicitlyCapturesThis.expected | Updated all path references from external library to local test file and adjusted line numbers for 16 query results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
unit tests).ql,.qll,.qlsorRules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.