feat(crashpad): consent-aware offline caching#1650
Draft
jpnurmi wants to merge 1 commit intojpnurmi/feat/cache-consentfrom
Draft
feat(crashpad): consent-aware offline caching#1650jpnurmi wants to merge 1 commit intojpnurmi/feat/cache-consentfrom
jpnurmi wants to merge 1 commit intojpnurmi/feat/cache-consentfrom
Conversation
|
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
from
4dcc514 to
a1bd38b
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-cache-consent
branch
from
c90479c to
c43b14d
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-cache-consent
branch
from
c43b14d to
4aed4b0
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-cache-consent
branch
from
4aed4b0 to
4813ada
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
from
a1bd38b to
9c2a6df
Compare
Wires UploadsPaused alongside UploadsEnabled from the consent handler: when consent is revoked and cache_keep or http_retry is enabled, pause crashpad uploads so pending reports are retained rather than skipped to completed. On consent transitions that re-enable uploads, call RequestRetry() so the handler wakes immediately instead of waiting for its next periodic scan. The crashpad submodule bump pulls in the matching UploadsPaused setting and RequestRetry IPC additions on the handler side. An integration test exercises the full flow: a crash captured while consent is revoked stays in crashpad's pending queue (no upload, not moved to completed), and giving consent in a subsequent run drains the pending report to the server. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-cache-consent
branch
from
4813ada to
ec97ffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements consent-aware offline caching for the Crashpad backend.
Note
Depends on
getsentry/crashpad#147
Wires
UploadsPausedalongsideUploadsEnabledfrom the consent handler: when consent is revoked andcache_keeporhttp_retryis enabled, pause Crashpad uploads so pending reports are retained rather than skipped to completed. On consent transitions that re-enable uploads, callRequestRetry()so the handler wakes immediately instead of waiting for its next periodic scan.The crashpad submodule bump pulls in the matching
UploadsPausedsetting andRequestRetryIPC additions on the handler side.An integration test exercises the full flow: a crash captured while consent is revoked stays in crashpad's pending queue (no upload, not moved to completed), and giving consent in a subsequent run drains the pending report to the server.
See also:
#skip-changelog (in #1542)