feat(cache): consent-aware offline caching#1542
Open
jpnurmi wants to merge 1 commit intojpnurmi/ref/run-consentfrom
Open
feat(cache): consent-aware offline caching#1542jpnurmi wants to merge 1 commit intojpnurmi/ref/run-consentfrom
jpnurmi wants to merge 1 commit intojpnurmi/ref/run-consentfrom
Conversation
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
2 times, most recently
from
680a83e to
24dc128
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/http-retry
branch
from
b133fd6 to
93db900
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
3 times, most recently
from
7cd8780 to
df20646
Compare
jpnurmi
changed the title
|
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
from
7398628 to
7118dbc
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jpnurmi
requested review from
JoshuaMoelans,
mujacica,
supervacuus and
tustanivsky
mujacica
approved these changes
Apr 13, 2026
This was referenced Apr 14, 2026
Draft
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4500595. Configure here.
This was referenced Apr 14, 2026
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
from
ade6ca2 to
4dcc514
Compare
This was referenced Apr 15, 2026
When user consent is required and currently revoked, route envelopes through the cache instead of discarding them, so they can be sent once consent is given. Caching is gated on cache_keep || http_retry — with neither, envelopes are still discarded (existing behavior). When http_retry is enabled, the retry poller stays alive while consent is revoked, and giving consent triggers an immediate retry pass so cached envelopes flush without waiting for the next poll. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpnurmi
force-pushed
the
jpnurmi/feat/cache-consent
branch
from
4dcc514 to
a1bd38b
Compare
Collaborator
Author
|
I split this into smaller, nicer to review PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements consent-aware offline caching for
inprocandbreakpad.nativeandcrashpadfollow in separate PRs.When a) user consent is revoked, and b)
cache_keepis enabled, cache envelopes to<db>/cache/instead of discarding them. Provided thathttp_retryis true, the retry module picks them up when consent is later given, or they can be sent manually viasentry_transport_retry().See also: