Repository navigation
fix: keep query params after a '?' in fromParameters - #492
Merged
Tony133 merged 2 commits intoNov 14, 2026
Merged
Conversation
Contributor
Author
|
The failing |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reply.fromParameters()splits the URL withsplit('?', 2). With a limit,splitdrops everything after the second?, so a request such as/api/echo?next=/a?b=1&c=2reaches the upstream as?next=%2Fa. Bothb=1andc=2are lost.A literal
?is valid inside a query string (RFC 3986, section 3.4), and it is common in redirect parameters.This change splits the URL on the first
?only. The new test proxies throughreply.fromParameters()andreply.from(), as shown in the README, and checks the query that the upstream receives.The default handler is not affected, because
@fastify/reply-fromforwards the original query string.Checklist
npm run test && npm run benchmark --if-presentand the Code of conduct
Fixes #491