Repository navigation
fix: preserve query parameters containing additional question marks in fromParameters - #495
Closed
abdul-karim-mia wants to merge 1 commit into
Closed
abdul-karim-mia wants to merge 1 commit into
abdul-karim-mia wants to merge 1 commit into
Conversation
…n fromParameters Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Member
|
CI is red |
Member
|
Thanks for the contribution! The issue has been fixed by #492, which was opened earlier with the same change, and released in v11.6.8, so I'm closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491.
In \extractUrlComponents(), the URL was previously split using \urlString.split('?', 2). In JavaScript, providing a limit to \String.prototype.split\ drops all remaining elements instead of grouping them into the last element. Consequently, when a query string contains additional literal ?\ characters (such as redirect or continuation parameters like ?next=/a?b=1&c=2, which are valid under RFC 3986 section 3.4), any characters and subsequent query parameters after the second ?\ were discarded.
This change:
eply.fromParameters().
All existing and new tests pass with 100% test and branch coverage, clean lint, and clean type tests.