Skip to content

ci: replace manual docker login with docker/login-action #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
einarwar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: replace manual docker login with docker/login-action #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/publish-image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ on:
required: false

env:
IMAGE_REGISTRY: ghcr.io
REGISTRY_USER: $GITHUB_ACTOR
API_IMAGE: ghcr.io/equinor/template-fastapi-react/api
NGINX_IMAGE: ghcr.io/equinor/template-fastapi-react/nginx

Expand All @@ -27,7 +25,11 @@ jobs:
fetch-depth: 2

- name: "Login to image registry"
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login $IMAGE_REGISTRY -u $GITHUB_ACTOR --password-stdin
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: "Build web"
run: |
Expand Down Expand Up @@ -61,7 +63,11 @@ jobs:
fetch-depth: 2

- name: "Login to image registry"
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login $IMAGE_REGISTRY -u $GITHUB_ACTOR --password-stdin
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: "Build API"
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/rollback.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ permissions:
id-token: write
packages: write

env:
IMAGE_REGISTRY: ghcr.io
API_IMAGE: ghcr.io/equinor/neqsimapi

jobs:
set-prod-tag:
runs-on: ubuntu-latest
Expand All @@ -29,14 +25,18 @@ jobs:
]
steps:
- name: "Login to image registry"
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login $IMAGE_REGISTRY -u $GITHUB_ACTOR --password-stdin
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: "Set prod tag on older image"
run: |
echo "Tagging ${{ matrix.image }}:${{ inputs.release-tag }} with 'production'"
docker pull ${{ matrix.image }}:${{ inputs.release-tag }}
docker tag ${{ matrix.image }}:${{ inputs.release-tag }} ${{ matrix.image }}:production
docker push $API_IMAGE:production
docker push ${{ matrix.image }}:production

# uncomment to apply rollback to radix
# deploy:
Expand Down
20 changes: 15 additions & 5 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ on:
required: false

env:
IMAGE_REGISTRY: ghcr.io
REGISTRY_USER: $GITHUB_ACTOR
API_IMAGE: ghcr.io/equinor/template-fastapi-react/api
WEB_IMAGE: ghcr.io/equinor/template-fastapi-react/web

Expand All @@ -22,7 +20,11 @@ jobs:
- uses: actions/checkout@v6

- name: Login to image registry
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login $IMAGE_REGISTRY -u $GITHUB_ACTOR --password-stdin
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build API image
run: |
Expand All @@ -37,7 +39,11 @@ jobs:
- uses: actions/checkout@v6

- name: Login to image registry
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login $IMAGE_REGISTRY -u $GITHUB_ACTOR --password-stdin
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build API image
run: |
Expand All @@ -57,7 +63,11 @@ jobs:
- uses: actions/checkout@v6

- name: Login to image registry
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login $IMAGE_REGISTRY -u $GITHUB_ACTOR --password-stdin
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build Web Image
run: |
Expand Down
Loading