ci: replace manual docker login with docker/login-action#477
Open
ci: replace manual docker login with docker/login-action#477
Conversation
- Replace 'echo $TOKEN | docker login' with docker/login-action@v3
across publish-image, tests, and rollback workflows
- Remove unused IMAGE_REGISTRY and REGISTRY_USER env vars
- Fix rollback bug: docker push was using wrong image var ($API_IMAGE
pointed to neqsimapi instead of ${{ matrix.image }})
einarwar
force-pushed
the
ci/use-docker-login-action
branch
from
279f703 to
03fb858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all manual
echo $TOKEN | docker loginCLI commands with the officialdocker/login-action@v3across CI workflows.Changes
All workflows (
publish-image,tests,rollback)echo ${{ secrets.GITHUB_TOKEN }} | docker login ... --password-stdinwithdocker/login-action@v3IMAGE_REGISTRYandREGISTRY_USERenv varsrollback.yaml— bug fixdocker push $API_IMAGE:productionwas referencingghcr.io/equinor/neqsimapi(a hardcoded wrong image) instead of${{ matrix.image }}. The push now correctly uses the matrix image variable.Why
docker/login-actionhandles credential masking, error handling, and automatic logout${{ github.actor }}(Actions expression) instead of$GITHUB_ACTOR(shell env var)