refactor(bazel): expose bundle-local Needs as JSON files - #901
Open
AlexanderLanin wants to merge 2 commits into
Open
AlexanderLanin wants to merge 2 commits into
AlexanderLanin wants to merge 2 commits into
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
October 2, 2026 20:01
Contributor
|
Documentation preview for this pull request is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is an internal Bazel improvement: it does not change the
docs()ordocs_bundle()API, or the generated documentation. Bundle-local Needs inventories are consumed asneeds.json, but their Bazel target currently represents Sphinx's whole output directory. Publishing the JSON file directly gives downstream targets the exact artifact they consume and removes the dependency on Sphinx's private output layout. It also gives the provider-based follow-up a clear file artifact to carry.What changed
.__internal__.needs_localtarget expose itsneeds.jsonfile directly.:needs_jsondirectory output for consumers of other Sphinx outputs such asmetrics.json.Closes #898