feat(bazel): resolve external Needs through providers - #902
Draft
AlexanderLanin wants to merge 1 commit into
Draft
AlexanderLanin wants to merge 1 commit into
AlexanderLanin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
external_needslets one documentation target use Needs from another. Today, our macro finds the inventory by deriving its private target name. If the input target is unsupported, the error can look like a missing generated target.This draft makes docs targets identify their own local Needs file, so the build can reject unsupported targets early. It adds clearer validation, but little user-facing behavior; the private names are only used by our own rules. This is the implementation to review against the decision in #899.
What changes
docs()anddocs_bundle()targets publish a reference to their local Needs file.external_needstargets and writes a manifest of the inventories to load.This PR is stacked on #901 and uses
issue-898-needs-json-fileas its base. Merge #901 first.