Skip to content

Remove redundant s_calls counter in async regression test #132781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 1 commit into from
Aug 27, 2026
Merged

Remove redundant s_calls counter in async regression test #132781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/tests/async/regression/132017.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
public class Runtime_132017
{
private static readonly List<string> s_log = new List<string>();
private static int s_calls;

// The nested catch starts this task without awaiting it; keep it around so
// that the test can wait for it deterministically.
Expand All @@ -20,7 +19,6 @@ public class Runtime_132017
public static void TestEntryPoint()
{
s_log.Clear();
s_calls = 0;
s_pending = null;

var test = new Runtime_132017();
Expand All @@ -29,7 +27,6 @@ public static void TestEntryPoint()
s_pending.GetAwaiter().GetResult();

Assert.Equal(new[] { "filter", "filter", "outer", "filter", "outer" }, s_log);
Assert.Equal(2, s_calls);
}

private static bool Filter(bool result)
Expand Down Expand Up @@ -69,6 +66,5 @@ private static async Task Print(Exception ex)
string message = ex.Message;
s_log.Add(message);
await Task.Yield();
s_calls++;
}
}