Remove redundant s_calls counter in async regression test - #132781
Merged
Conversation
The counter was incremented after an await, so the fire-and-forget Print and the awaited Print could race on the non-atomic increment. It also did not add coverage: both tasks are already joined, and s_log records the handler behavior the test is actually about. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d2b6737d-550f-4473-a6a7-a687c8fc6819
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Runtime_132017 async regression test by removing the s_calls counter, which was updated after an await and could race, causing intermittent failures. The test continues to validate the intended behavior via the existing ordered s_log assertions and deterministic task joining.
Changes:
- Removed the static
s_callsfield and its reset/increment logic. - Dropped the
Assert.Equal(2, s_calls)assertion, relying ons_log’s ordered contents to validate the twoPrintexecutions.
Member
Author
|
cc @dotnet/jit-contrib PTAL @EgorBo |
EgorBo
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The counter was incremented after an await, so the fire-and-forget Print and the awaited Print could race on the non-atomic increment. It also did not add coverage: both tasks are already joined, and s_log records the handler behavior the test is actually about.
Fix #132731