Skip to content

build-image: build faillint against current x/tools #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SungJin1212 wants to merge 1 commit into from
Closed

build-image: build faillint against current x/tools #7815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion build-image/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,19 @@ RUN go install github.com/client9/misspell/cmd/misspell@v0.3.4 &&\
go install github.com/golang/protobuf/protoc-gen-go@v1.3.1 &&\
go install github.com/gogo/protobuf/protoc-gen-gogoslick@v1.3.0 &&\
go install github.com/weaveworks/tools/cover@bdd647e92546027e12cdde3ae0714bb495e43013 &&\
go install github.com/fatih/faillint@v1.15.0 &&\
go install github.com/campoy/embedmd@v1.0.0 &&\
rm -rf /go/pkg /go/src /root/.cache

# Go 1.27 writes export data at pkgbits V4, but faillint v1.15.0 pins
# golang.org/x/tools v0.30.0, whose decoder stops at V2. `go install` would use
# faillint's own pinned version, so build it against a current x/tools instead.
RUN mkdir /tmp/faillint && cd /tmp/faillint && \
go mod init faillint-build && \
go get github.com/fatih/faillint@v1.15.0 && \
go get golang.org/x/tools@v0.49.0 && \
go build -o /usr/bin/faillint github.com/fatih/faillint && \
cd / && rm -rf /tmp/faillint /go/pkg /go/src /root/.cache

COPY build.sh /
ENV GOCACHE=/go/cache
ENTRYPOINT ["/build.sh"]
Expand Down