build-image: build faillint against current x/tools - #7815
Closed
SungJin1212 wants to merge 1 commit into
Closed
Conversation
faillint v1.15.0 pins golang.org/x/tools v0.30.0, which cannot read the export data produced by Go 1.27. Build it in a throwaway module with an up-to-date x/tools so the lint step keeps working across Go upgrades. Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
4 tasks
4 tasks
Member
Author
|
#7816 is better than this PR; close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Go 1.27 bumped the version of the compiler's export data format (unified IR /pkgbits) from V2 to V4. faillint v1.15.0 pins golang.org/x/tools v0.30.0, whose decoder only understands up to V2, so it can no longer read type information for imported packages.
There is no newer faillint release to upgrade to (v1.15.0 is the latest, and upstream has had no commits since March 2025).
go install github.com/fatih/faillint@v1.15.0always resolves x/tools from faillint's owngo.mod, so instead the build image now builds faillint in a throwaway module that requires a current x/tools.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags