🤖 fix: keep waiting for Codex approval after informational results - #4151
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
0748206 to
790b6a7
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 790b6a75f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
790b6a7 to
8d67b6a
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d67b6a787
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8d67b6a to
079fdb7
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Reuse the classifier merged in #4149 without changing its blocking policy. Completed status and no-findings results remain pending until explicit approval, while findings and account errors still fail. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$24.58`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=24.58 -->
ammar-agent
changed the title
079fdb7 to
ce98eb6
Compare
|
@codex review #4149 merged during review. Rebased onto current main, preserved its classifier and CI policy unchanged, and removed our duplicate implementation/test harness. This PR is now a two-file waiter follow-up plus regression tests: completed informational envelopes keep polling for explicit approval rather than failing; unfinished/unknown envelopes, findings, and account errors still block. All 11 regression groups and static checks pass. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
2 participants
Summary
Follow up on #4149 so completed informational Codex results do not make the review waiter fail before its explicit approval signal arrives. The classifier fix merged while this PR was under review; this PR now preserves that implementation unchanged and contains only the missing waiter behavior and regression coverage.
Implementation
Validation
make test-codex-commentspasses all 11 regression groups, including completed-result polling, stale/foreign approval signals, findings alongside informational comments, and account errors.make static-checkpasses.Risks
This only changes the waiter’s non-terminal state; the CI classifier, comment-resolution checks, and approval/freshness requirements are unchanged.
Generated with
xum• Model:openai:gpt-6-astra• Thinking:xhigh• Cost:$24.58