🤖 fix: preserve spacing around nested code execution tools - #4150
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex completed both code and security review with no findings, and its approval remains visible. Marking the completed status summary and clean security result as resolved: the current Codex Comments checker mistakes these informational comments for unresolved findings. No review findings or threads are being dismissed. Rerunning the check without broadening this spacing-only PR. |
|
@codex review Rebased onto the separate checker fix in #4151. The spacing-only diff is unchanged. Restored both informational bot comments; the corrected checker now passes with them visible. Revalidated static checks, checker regressions, renderer tests, and all seven full-app desktop/phone stories. |
fa36684 to
8f9c3f4
Compare
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
8f9c3f4 to
fea601d
Compare
This comment has been minimized.
This comment has been minimized.
|
@codex review Retrying the previous Codex service failure (Unknown error). No code changes since the last request; marking that failed-request notification outdated while this new review runs. |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fea601d to
301a4a8
Compare
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Keep shared parent gutters intact instead of requiring per-tool spacing fixes. Add desktop and phone geometry regressions. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$15.92`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=15.92 -->
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review Rebased onto current main and the reduced #4151 waiter follow-up. The checker implementation from merged #4149 is preserved unchanged; this PR still contains only the two spacing files. Static checks, all 11 checker regression groups, and all 7 full-app desktop/phone stories pass locally. |
301a4a8 to
9f03376
Compare
This comment has been minimized.
This comment has been minimized.
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review Retrying the code-review service request that returned Unknown error. No code changes. The failed-request notification is outdated; explicit approval is still required for this revision. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
2 participants
Summary
Keep all nested tool cards inset from the Code Execution border. The shared nested-tools container was cancelling its parent's horizontal padding with negative margins, so bordered cards such as
task_send_messagesat against the dashed frame. Removing that override fixes the shared layout rather than adding tool-specific spacing workarounds.Validation
agent_report,file_read, andtask_send_message, including collapsed/expanded message cards. Geometry assertions verify border clearance, separation between tools, and no horizontal overflow.make static-checkpassed; 7 full-app Storybook tests and 63 targeted tool-renderer/unit tests passed.Existing local validation limitation
The isolated
CodeExecutionToolCallgallery has a Vite development-time circular-import error (Cannot access 'CodeExecutionToolCall' before initialization). Reproduced with the original production file as well. The full-app code-execution and agent-communication stories pass.Generated with
xum• Model:openai:gpt-6-astra• Thinking:xhigh• Cost:$24.54