Skip to content

fix(ci): run changeset release as bombshell-bot app #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
natemoo-re wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

fix(ci): run changeset release as bombshell-bot app #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,25 @@ jobs:
pull-requests: write # open the "Version Packages" PR
id-token: write # npm publish via OIDC trusted publishing
steps:
- name: generate bot token
id: bot-token
uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3.2.0
with:
app-id: ${{ secrets.BOT_APP_ID }}
private-key: ${{ secrets.BOT_PRIVATE_KEY }}

- name: checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
submodules: true
fetch-depth: 0
persist-credentials: true
token: ${{ steps.bot-token.outputs.token }}

- name: setup git user
run: |
git config --global user.name "bombshell-bot[bot]"
git config --global user.email "187071675+bombshell-bot[bot]@users.noreply.github.com"

- name: setup deno
uses: denoland/setup-deno@22d081ff2d3a40755e97629de92e3bcbfa7cf2ed # v2.0.5
Expand Down Expand Up @@ -55,4 +69,4 @@ jobs:
create-github-releases: false
push-with-git-cli: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ steps.bot-token.outputs.token }}

@trueberryless trueberryless Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work. Please pass the token via the github-token parameter!

If you wonder why it worked with the default token then, the reason is that changesets does a check internally if the env var and the parameter are equal and because the parameter defaults to the GITHUB_TOKEN, it passes. With this current change however, it would through.

See https://github.com/changesets/action/blob/371fd77b45f11aeffd80c5ad40f2062fd5986bde/src/index.ts#L35-L41

Loading