fix(ci): run changeset release as bombshell-bot app - #123
Open
natemoo-re wants to merge 1 commit into
Open
Conversation
The Publish workflow passed the default `secrets.GITHUB_TOKEN` to `changesets/action`, so the "Version Packages" PR, the version-bump commit, and the release tag were all attributed to `github-actions[bot]` instead of our `bombshell-bot` GitHub App like the other Bombshell repos. Mint an installation token from the org-level `BOT_APP_ID` / `BOT_PRIVATE_KEY` secrets via `actions/create-github-app-token`, check out with it so the persisted git credentials push as the app, set the git user to the app identity so the bump commit is authored by it, and hand the token to `changesets/action` so it opens the PR as the app. tty can't reuse `bombshell-dev/automation`'s publish workflow (that one builds with pnpm/Node; tty builds WASM via make + Deno), so the app-token pattern is inlined here. `push-with-git-cli: true` stays because the clay submodule gitlink breaks the GitHub-API push path (0e10dcd), which is also why the git-user config is needed for commit authorship.
commit: |
natemoo-re
marked this pull request as ready for review
September 1, 2026 21:39
jbolda
approved these changes
Sep 1, 2026
trueberryless
suggested changes
Sep 2, 2026
| push-with-git-cli: true | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ steps.bot-token.outputs.token }} |
There was a problem hiding this comment.
This will not work. Please pass the token via the github-token parameter!
If you wonder why it worked with the default token then, the reason is that changesets does a check internally if the env var and the parameter are equal and because the parameter defaults to the GITHUB_TOKEN, it passes. With this current change however, it would through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#122 was creating using changeset's default
GITHUB_TOKENfromgithub-actions[bot]now our action mints a
bombshell-botapp token from the org secretsBOT_APP_ID/BOT_PRIVATE_KEY, checks out with it, sets the git author to the app, and hands it to changesets