Skip to content

Prevent command injection via SolrBackup.spec.location #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apvxlab wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Prevent command injection via SolrBackup.spec.location #844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion controllers/util/backup_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,14 @@ func EnsureDirectoryForBackup(solrCloud *solr.SolrCloud, backupRepository *solr.
// Directory creation only required/possible for volume (i.e. local) backups
if IsRepoVolume(backupRepository) {
backupPath := BackupLocationPath(backupRepository, backup.Spec.Location)
// Exec mkdir directly (argv form) rather than through "/bin/bash -c".
// backupPath is derived from the user-controlled SolrBackup.spec.location;
// passing it through a shell allowed command injection. As a discrete argv
// element it is treated as a literal path and shell metacharacters are inert.
return RunExecForPod(
solrCloud.GetAllSolrPodNames()[0],
solrCloud.Namespace,
[]string{"/bin/bash", "-c", "mkdir -p " + backupPath},
[]string{"mkdir", "-p", backupPath},
config,
)
}
Expand Down
Loading