[Variant] Add nested object and array interoperability tests - #10637
Open
cakeni wants to merge 1 commit into
Open
[Variant] Add nested object and array interoperability tests#10637cakeni wants to merge 1 commit into
cakeni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The Variant interoperability suite covers primitive objects and arrays but does not exercise the nested object and array fixtures. This leaves nested
VariantBuilderencoding without equivalent fixture-based coverage.What changes are included in this PR?
object_nestedfixture with nested object builders and compare it with the decoded interoperability fixture.array_nestedfixture with nested object/list builders, including null values, and compare it with the decoded fixture.Are these changes tested?
Yes. Both new tests pass against
apache/parquet-testingcommit73545118:cargo test -p parquet-variant --test variant_interop variant_object_nested_buildercargo test -p parquet-variant --test variant_interop variant_array_nested_builderAre there any user-facing changes?
No. This PR adds test coverage only.