Replace substring BufferBuilders with Vec - #10634
Open
cakeni wants to merge 1 commit into
Open
Conversation
Rich-T-kid
approved these changes
Aug 11, 2026
Contributor
|
@cakeni i noticed you raised quite a lot of PRs in a short span of time; especially these PRs have the same timestamps:
could you explain this? are they truly PRs raised by you or was there an AI agent involved with this? |
Contributor
Author
|
Yes, AI assistance was involved in preparing some of these PRs. I reviewed the changes, diffs, and test results before submitting them. The similar timestamps are because I was working on several independent issues in parallel and submitted the PRs around the same time. I understand that opening several PRs at once can make review harder for maintainers, so I’ll slow down and wait for feedback on the existing PRs before opening more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #10245.
Rationale for this change
Vecprovides the same capacity preallocation and append behavior needed bysubstring_by_char_implwithout the additionalBufferBuilderabstraction.What changes are included in this PR?
BufferBuilderwithVec<u8>.BufferBuilderwithVec<OffsetSize>.Are there any user-facing changes?
No.
How was this change tested?
cargo +stable-x86_64-pc-windows-gnu fmt --all -- --checkcargo +stable-x86_64-pc-windows-gnu clippy -p arrow-string --all-targets --all-features --no-deps -- -D warningscargo +stable-x86_64-pc-windows-gnu test -p arrow-string --all-features(182 unit tests and 10 doc tests passed)