Skip to content

Detect stale metrics registry entries in the metrics sync prek hook#69578

Draft
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-prek-metrics-hook
Draft

Detect stale metrics registry entries in the metrics sync prek hook#69578
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:airflow-prek-metrics-hook

Conversation

@FrankYang0529

Copy link
Copy Markdown
Member

Why

  • check-metrics-synced-with-registry only checks one direction: a metric used in code but missing from metrics_template.yaml.
  • A registry entry no longer emitted anywhere was undetected.

How

  • The check scans all git-tracked non-test Python files (git ls-files). It checks any registry entry with no matching metric in code.
  • Add an INDIRECTLY_EMITTED_METRICS allowlist for the three executor.* gauges whose names are built via BaseExecutor._get_metric_name() and cannot be resolved statically.

Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@FrankYang0529 FrankYang0529 force-pushed the airflow-prek-metrics-hook branch 2 times, most recently from 214a3a6 to a8e4b57 Compare July 8, 2026 06:51
Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529 FrankYang0529 force-pushed the airflow-prek-metrics-hook branch from a8e4b57 to 544fd7f Compare July 8, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant