Remove stale metrics no longer emitted from the metrics registry#68945
Conversation
dag_processing.manager_stalls, dag_file_refresh_error, and collect_db_dags describe metrics whose emission was removed in earlier refactors (apache#45729, apache#44972, apache#53918) Signed-off-by: PoAn Yang <payang@apache.org>
SameerMesiah97
left a comment
There was a problem hiding this comment.
I searched for these metrics in main and I could find them being emitted anywhere. I do wonder why they were not removed from .yaml file? I want to make sure removing them from the registry won't impact any tooling that relies on the template rather than the emitted metrics themselves. This looks fine to me but let's wait for a maintiainer to weigh in.
Lee-W
left a comment
There was a problem hiding this comment.
make sense to me. probably also worth a quick confirm from @ashb @jedcunningham and @uranusjr (the original author of the PRs).
we can also add a prek hook to check. e.g., if we add or remove a metrics, we trigger this hook to compare the metric in the doc and in the code
Created a followup PR. Thank you. |
Remove the three orphaned entries from
metrics_template.yaml:dag_processing.manager_stalls— emission removed in Remove dag processor from the scheduler #45729dag_file_refresh_error— emission removed in Swap Dag Parsing to use the TaskSDK machinery. #44972collect_db_dags— emission removed in Move DagBag to SDK and make it return SDK DAG objects #53918Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.